Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I tried to use grab and tested download from server https://speed.hetzner.de
When I retried download to partially saved file grab failed with
nil
response and errorHead EOF
I've researched the source of the problem. Remote server breaks the connection on HEAD request, but works good at GET request. So, I think that in this case grab should not fail after HEAD and go further and try GET.
This PR fixes this.
Solution
Test
I've added test that emulate HEAD request breaking connection
WithHeadRequestBreak
.Fix
In headRequest State Function in branch with response error grab now does not closing the response but go to GET request.
client.Do(req)
returns onlynil
response along with error, so there is no need to close nil response.Other fixes
I've added one more commit to PR with linter fixes and update of the Go version.