Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix head break connection #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mehanizm
Copy link

Problem

I tried to use grab and tested download from server https://speed.hetzner.de
When I retried download to partially saved file grab failed with nil response and error Head EOF

I've researched the source of the problem. Remote server breaks the connection on HEAD request, but works good at GET request. So, I think that in this case grab should not fail after HEAD and go further and try GET.

This PR fixes this.

Solution

Test

I've added test that emulate HEAD request breaking connection WithHeadRequestBreak.

Fix

In headRequest State Function in branch with response error grab now does not closing the response but go to GET request.

client.Do(req) returns only nil response along with error, so there is no need to close nil response.

Other fixes

I've added one more commit to PR with linter fixes and update of the Go version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant